barryross
commented
7 years ago Hey Amy,
You are doing some great things here. Nice work implementing the media query, and using relative em units in places.
The marks I left off were related to: a horizontal scroll bar appearing at times when testing the layout at smaller screens - this relates to ensuring content is visible to the user. I gave partial, because much of the content remains visible, but we do want to avoid that scrollbar from appearing, and ensure all the page info (including white space) remains visible to the user.
I see you were adjusting margins/paddings for a number of elements in your media query which is great. I would encourage you to center content on mobile versions (when it is in a single-column, which it often will be), as this is one of the more common adjustments to make with alignment/margins/padding
Lastly, I noticed the blog remained as two columns, so I left the marks off for that one. Please let me know if you have any questions and see inline comments for additional notes!
FEWD Week #7 Project: Responsive Design
Description
Relaxr's user count has grown, and the number of users accessing the site from a mobile device has surprised everyone, even by today's standards. The product managers at Relaxr have asked you to return to the project and make their site responsive so it renders nicely on mobile devices. They had one of their internal developers make a few tweaks to your source code, and they have given you the new HTML / CSS files to work from. Using these starter files, build out the mobile layouts for the landing page and blog.
Student: Amy Berkhoudt
Project URL: https://github.com/amy-b/homework-responsive__
divs