search

amy-jung / collectivedaoarchives.catalog

The Collective DAO Catalog is an open source index of DAO historical events. Together, as an open source database that anyone can contribute to, we can use the power of collective intelligence to highlight patterns and improve the development of new and existing DAOs
https://www.daocatalog.xyz/
MIT License
6 stars 1 forks source link

Add advanced search #58

Closed damianmarti closed 7 months ago

damianmarti commented 7 months ago

Added search features to the backend:

Added backend endpoints to get categories and organizations.

Added advanced search to the frontend:

The advanced search form looks ugly, it needs to be styled.

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
collectivedaoarchives-catalog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2024 0:17am
carletex commented 7 months ago

Thanks for this @damianmarti !! Looking great!

I've been testing and I found one issue with organizations: when I manually set the organizations to filter + click search, it doesn't work (it returns all the records). See screenshot (URL query not right, it's empty). I see that setOrganizations is not used, so that might be it?

image

carletex commented 7 months ago

The advanced search form looks ugly, it needs to be styled.

I'll work on this BTW ;)

damianmarti commented 7 months ago

Thanks for this @damianmarti !! Looking great!

I've been testing and I found one issue with organizations: when I manually set the organizations to filter + click search, it doesn't work (it returns all the records). See screenshot (URL query not right, it's empty). I see that setOrganizations is not used, so that might be it?

image

I did a refactor before pushing the code, maybe I introduce a bug there. I will check it!

damianmarti commented 7 months ago

Thanks for this @damianmarti !! Looking great! I've been testing and I found one issue with organizations: when I manually set the organizations to filter + click search, it doesn't work (it returns all the records). See screenshot (URL query not right, it's empty). I see that setOrganizations is not used, so that might be it? image

I did a refactor before pushing the code, maybe I introduce a bug there. I will check it!

@carletex what do you mean by "manually set the organizations to filter"? Thanks!

carletex commented 7 months ago

@damianmarti

What I meant by "manually" is that I didn't click on an organization on a record page.

Steps I followed:

1 Go to the search page,

  1. select gitcoin & aave in the organzations field
  2. click search
  3. The page loads and the results are empty (the URL didn't change, I get a "?q=").

Doing the same with "dates" work!

carletex commented 7 months ago

Thanks @damianmarti, seems to be working great now!!

Even if we don't have the styles for it, let's merge so we can test live... and I'll do the styling tweaks in another PR