search

amyasnikov / validity

NetBox plugin to validate network devices
MIT License
123 stars 7 forks source link

Server Error 500 Adding a Data Source #110

Open aascedu opened 3 hours ago

aascedu commented 3 hours ago

Validity Version

3.0.0

NetBox Version

>=4.0

Python Version

3.12.3

Steps to Reproduce

Add a data source with validity installed Linked issue : https://github.com/netbox-community/netbox/issues/14279 Probably this file : https://github.com/amyasnikov/validity/blob/a490f08424cdfc7d74a136abcc5576db4fd21384/validity/custom_validators.py#L9 Look for the same prototype as in this file : https://github.com/netbox-community/netbox/blob/6b219a279b3137cce351a2b48e0fb32155311aec/netbox/extras/validators.py#L168

Traceback

image

amyasnikov commented 2 hours ago

Hey @aascedu, you're right with the root cause of the error, it's https://github.com/netbox-community/netbox/issues/14279 where an extra argument to custom validators has been added. Although it's not very polite from NetBox devs' side - to force changing the signature of all existing custom validators for all the users/developers, all I can do is to fix it.

As an immediate fix you can temporarily remove the custom validator from your configuration.py

aascedu commented 2 hours ago

Thank you so much, I downgraded my Netbox version to 3.7 which is style functional. I will wait for your fix as it shouldn’t take long to update. Thank you so much for being as reactive as that ! You will make work easier when it’s fixed ;)

Have a good one. Arthur

On Fri 20 Sep 2024 at 17:06, Anton @.***> wrote:

Hey @aascedu https://github.com/aascedu, you're right with the root cause of the error, it's netbox-community/netbox#14279 https://github.com/netbox-community/netbox/issues/14279 where an extra argument to custom validators has been added. Although it's not very polite from NetBox devs' side - to force changing the signature of all existing custom validators for all the users/developers, all I can do is to fix it.

As an immediate fix you can temporarily remove the custom validator from your configuration.py

— Reply to this email directly, view it on GitHub https://github.com/amyasnikov/validity/issues/110#issuecomment-2363949098, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2DITZAS2JGAXXPRN5FPTOLZXQ2YVAVCNFSM6AAAAABOSFIVJCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRTHE2DSMBZHA . You are receiving this because you were mentioned.Message ID: @.***>