search

amyjko / faculty

Amy's faculty webpage
Creative Commons Zero v1.0 Universal
22 stars 23 forks source link

CER Component addition #122

Closed aakash1104 closed 3 years ago

aakash1104 commented 3 years ago

Hi, I see that you have a cer.js as well as a separate github gist cer.md. From what I can tell, the JS component doesn't seem to use/import the gist? I do have a few faculty additions I'd like to submit. I don't think I can submit a pull request for Github Gists. Could I make a pull request by updating the cer.js file? This probably won't update the github gist you maintain.

amyjko commented 3 years ago

Hello Aakash! Thanks for catching this; I migrated the Gist content to my faculty web page recently (Gists are kind of limited). I need to delegate the Gist. Submitting a pull request on cer.js works for me!

aakash1104 commented 3 years ago

Hi hi hi! :) Just submitted a PR (https://github.com/amyjko/faculty/pull/123) for this.

Have you considered using something like AirTable to maintain a list of faculty who do research in CER? That way you can even add filters easily to search for faculty and also embed this on webpages!

Cheers!

amyjko commented 3 years ago

Thank you! Comments on the PR.

I haven't thought about using AirTable (I have so little time to work on this site), but it's a good idea. Feel free to file an issue if you like.

aakash1104 commented 3 years ago

I'll create another issue and find some AirTable resources. I found another repo that I reference often that uses AirTable. I'll try to find something concrete and create an issue. But you can go ahead and close this issue.

amyjko commented 3 years ago

Thanks!