search

amyleew / osrm-frontend

Frontend interface for project OSRM directions
http://amyleew.github.io/osrm-frontend/
1 stars 0 forks source link

Remove geocode control box from routing instructions #14

Closed amyleew closed 9 years ago

amyleew commented 9 years ago

@tristen - Having trouble identifying where my control box is connected to the routing instructions but they are clearly connected.

How can I best trouble-shoot this?

image

amyleew commented 9 years ago

On this http://amyleew.github.io/osrm-frontend/ I'm trying to get the control box separate from the routing instructions like on my http://amyleew.github.io/lrm/ version within the npm install.

image

tristen commented 9 years ago

Discussed offline with @amyleew. It looks like the parent container (right sidebar) has it's container set overflow:auto which prevented the fixed positioned geocoding container from appearing.

Ideally, the geocoding container is never contained within that sidebar and appended to the map element independently. Looking at http://www.liedman.net/leaflet-routing-machine/api/ it doesn't look like its really possible to do.

tristen commented 9 years ago

https://github.com/perliedman/leaflet-routing-machine/issues/135

amyleew commented 9 years ago

@tristen - I was able to successfully sever the geocoder input for the direction instructions... leaflet-routing-alternatives-container and .osrm-directions-inputs had the same styling

However now I can't control the overflow: auto so I can scroll longer routing instructions. Try to replace in the parent container and the direction instructions classes but no luck. Am I missing something?

image

tristen commented 9 years ago

You'll want to give its parent container overflow of auto and a height of 100%. Make sure there isn't any weird positioning rules applied to it.

amyleew commented 9 years ago

Yes!! height: 100%; thanks! Fixed https://github.com/amyleew/osrm-frontend/commit/b5b9936a731992f5a6d2d1ab2b23f595f3507ad2