Python branch stops working randomly

[Mikaela]

Sometimes push works directly when ZNC is started, but often it requires /znc updatemod push or push won't do anything nor reply to commands sent to it other than /znc *push which gives the "Hello, how can I help you?` line. That just happened again and that is why I am opening the issue.

• ZNC 1.5-git-205-0908023

  • IPv6: yes, SSL: yes, DNS: threads, charset: yes

  my uptime is currently 1w 21h 18m 48s so it cannot be related to starting ZNC.

• Python 3.4

% pip freeze|grep requests
requests==2.4.0
requests-oauthlib==0.4.1

And requests can be imported in Python console.

[amyreese]

I've gotten reports of this eventual hang from a few people, but haven't experienced it yet myself. I'm suspecting that it's an issue with either the modpython implementation itself (the "how can I help" line is not from my module), or caused by network issues while sending push notifications. The former issue, I have no idea how to either diagnose or work around; but the latter issue, I'm planning to mitigate by spawning a background thread for the network requests, which should also fix the current problem with requests blocking the main ZNC thread, which affects multiuser installs.

And fwiw, I've been running push.py on my ZNC install for many weeks now without reloading it, and my ZNC uptime is 15w 1d 17h 23m 32s.

[Mikaela]

At #znc at freenode on 2014-09-22:

[19:30:40] <Mikaela> jreese: [2014-09-22 19:29:59.209247] modpython: Mikaela/push/OnChanMsg failed: Traceback (most recent call last):\x0A  File "/home/users/mkaysi/.znc/
modules/push.py", line 733, in OnChanMsg\x0A    with Context(self, title=T.channel_push, message=message,\x0AAttributeError: 'NoneType' object has no attribute 'channel_p
ush'\x0A
[19:30:42] <Mikaela> appears in znc -D several times
[19:31:03] <nw`> I gotta run, will be back later.
[19:31:52] <Mikaela> jreese: *push has also stopped responding, could this be related to that issue?
[19:32:31] <Mikaela> jreese: After /znc updatemod push, the traceback message stops appearing.
[19:32:45] <Mikaela> And the module replies to commands.
[19:32:54] <Nothing4You> Mikaela: error will come back sooner or later
[19:33:59] <Mikaela> Nothing4You: Do you think those two things are related?
[19:34:40] <Nothing4You> Mikaela: *push keeps dying here with pushbullet, probably related
[19:34:40] *** Quits: raymondhim (~raymondhi@jessica.totalsyssolutions.net) (Quit: Nothing at all!)
[19:34:44] <Nothing4You> not entirely sure
[19:34:51] <Mikaela> I am using Pushover.

I am not sure if these messages were ever seen at IRC, but I don't remember getting any kind of answer so I am posting this here just in case.

[amyreese]

Thanks, I was out of town over the weekend. I'll look into it.

John Reese noswap.com

On Wed, Sep 24, 2014 at 6:21 AM, Mikaela Suomalainen < notifications@github.com> wrote:

At #znc at freenode on 2014-09-22:

[19:30:40] jreese: [2014-09-22 19:29:59.209247] modpython: Mikaela/push/OnChanMsg failed: Traceback (most recent call last):\x0A File "/home/users/mkaysi/.znc/ modules/push.py", line 733, in OnChanMsg\x0A with Context(self, title=T.channel_push, message=message,\x0AAttributeError: 'NoneType' object has no attribute 'channel_p ush'\x0A [19:30:42] appears in znc -D several times [19:31:03] <nw`> I gotta run, will be back later. [19:31:52] jreese: push has also stopped responding, could this be related to that issue? [19:32:31] jreese: After /znc updatemod push, the traceback message stops appearing. [19:32:45] And the module replies to commands. [19:32:54] Mikaela: error will come back sooner or later [19:33:59] Nothing4You: Do you think those two things are related? [19:34:40] Mikaela: push keeps dying here with pushbullet, probably related [19:34:40] * Quits: raymondhim (~raymondhi@jessica.totalsyssolutions.net) (Quit: Nothing at all!) [19:34:44] not entirely sure [19:34:51] I am using Pushover.

I am not sure if these messages were ever seen at IRC, but I don't remember getting any kind of answer so I am posting this here just in case.

— Reply to this email directly or view it on GitHub https://github.com/jreese/znc-push/issues/116#issuecomment-56668198.

[amyreese]

Sorry for the long delay, I finally got around to doing some testing, and took the opportunity to restart my main ZNC instance with -D and piping the logs to a file. I was able to replicate the error you were getting, and it looks like it was related to having a default "lang" setting of "en_ca" instead of "en_us". After updating the default value, and doing "/msg *status updatemod push", I haven't seen that error any more.

I pushed that change last night, and my error logs are still clear this morning, so try that out when you get the chance. Let me know if that solves the random hangs for you as well. If it doesn't, then I'll keep digging. Cheers.

[Mikaela]

I updated push.py now. How long time should I wait before deciding that it works or doesn't work?

[amyreese]

Good question. How often were you experiencing the hangs?

[Mikaela]

I don't know, it just stopped working randomly without any warnings and I always needed to see highlights at IRC before I knew that it had stopped working.

[Mikaela]

It just did it again.

[mgedmin]

Encountered this today for the first time.

What I did:

• installed znc 1.6.0 on a trusty server (from tewards's PPA)
• cloned znc-push with -b python
• copied over my ~/.znc from my precise server (which had znc 1.6.0 and push.so but no znc-python because libpython3.2 in precie was too old)
• rm'ed ~/.znc/modules/push.so
• ran 'make install' in znc-push, got ~/.znc/modules/push.pyc
• edited ~/.znc/configs/znc.conf and added LoadModule = modpython to the top
• checked the config, saw that 'push' was loaded once, as a user module
• launched znc
• checked webadmin, saw that push was loaded
• asked people to msg me privately, didn't get notified
• tried to talk to *push, didn't get any response to 'help', or 'get' or 'dump'

Then I tried a workaround:

• copied push.py into ~/.znc/modules/
• /znc unloadmod push; /znc loadmod push (I didn't know about /znc updatemod)
• tried to talk to *push, it started responding to commands ('help', 'send test' both worked)

I'm using PushBullet for push notifications, in case that matters.

[peetsnack]

I am also seeing a similar issue on my install. znc-push v2.0.0-rc, python 3.4.0

Push stops working after a few days. Run reloadmod and it comes back up.

[PaulFreund]

I am also encountering this problem. Interestingly no command works except for the version command.

[stevesbrain]

For me, I'm experiencing this with ZNC 1.6.0, using Pushover as the service. Built from source. Previously had the C version installed alongside ZNC 1.4.0.

[stevesbrain]

I'm happy to assist in more in-depth testing with this, however, my knowledge of how to actually assist is limited. If anyone is happy to let me know what tools/modes/etc they would like me to run, I'll gladly provide any info. I'm still experiencing this issue with updated versions of ZNC and the Py module along the way, and would love to get it resolved :)

[djfjeff]

I have encountered this issue today with Push stopping to work two times during the day. It is now working fine for a couple of hours.

I tried to see where I can look to debug this but didn't go very far for the moment.

My config is ZNC 1.6.3 on Fedora 23 with the latest znc-push python from git.