amyreese / znc-push

Push notification service module for ZNC
http://noswap.com/projects/znc-push
MIT License
556 stars 122 forks source link

Amazon SNS Support #81

Open jantman opened 10 years ago

jantman commented 10 years ago

It would be really nice if this also supported Amazon SNS

http://aws.amazon.com/documentation/sns/

amyreese commented 10 years ago

Agree that this would be nice to have, any code contribution would be welcome. :P

John Reese john@noswap.com

On Tue, Apr 15, 2014 at 7:17 PM, Jason Antman notifications@github.com wrote:

It would be really nice if this also supported Amazon SNS

http://aws.amazon.com/documentation/sns/

Reply to this email directly or view it on GitHub: https://github.com/jreese/znc-push/issues/81

jantman commented 10 years ago

I don't recall ever writing a single line of C++ before, but I'll give it a shot. I gather from the repo that there aren't any tests for this - just manual testing?

amyreese commented 10 years ago

It should hopefully be pretty straightforward; just copy-paste some of the blocks of code for existing service types, and modify them to fit the SNS API. And yes, testing is generally down to manual testing.

John Reese noswap.com

On Fri, Apr 18, 2014 at 3:45 PM, Jason Antman notifications@github.comwrote:

I don't recall ever writing a single line of C++ before, but I'll give it a shot. I gather from the repo that there aren't any tests for this - just manual testing?

— Reply to this email directly or view it on GitHubhttps://github.com/jreese/znc-push/issues/81#issuecomment-40851018 .

jantman commented 10 years ago

Thanks for the info. So for the time being, I think I've decided to throw in the towel on SNS and just use one of the already-supported options. If I change my mind, I'll send a PR along.

amyreese commented 10 years ago

Another random thought I had: znc-push supports sending http requests to custom URLs. If the SNS API is relatively simple, you should be able to configure znc-push to hit the SNS API with the appropriate get/post payload.

Strykar commented 4 years ago

+1 AWS SNS has a 1 million messages/month free tier.