amyxzhang / squadbox

Fight harassment with your squad.
https://squadbox.org
MIT License
24 stars 7 forks source link

Bug with accepting moderated emails from the same account in Gmail #54

Closed amyxzhang closed 6 years ago

amyxzhang commented 6 years ago

I just sent two test emails from the same account to another account that used squadbox, with slightly different subject line and message body one after the other. I then logged in as a moderator and accepted the first email (without adding the user to the whitelist). Immediately both emails were moved out of the owner's trash into the owner's regular inbox. The 2nd email was still in the mod queue, even thought it was now already in the owner's main inbox. This happened in GMail.

I haven't tested what was the cause of this bug.

kmahar commented 6 years ago

ah, I see the problem. here we use the first word in the subject plus the sender to untrash it. I am guessing this was because I wasn't sure if the query would work with a space in the subject at the time I wrote it, but from testing in my own inbox now a search seems to work ok with "subject:multiple words here" so I think we can stop splitting the subject line. on my work laptop right now so I'm not set up to fix/test this, but I can do so when I get home tonight