amzhy / pe

0 stars 0 forks source link

User is able to edit an existing name to that of another patient that already exists #2

Open amzhy opened 2 years ago

amzhy commented 2 years ago

Reproduce using:

  1. edit 1 n/Bobby Yu [whitespace] [whitespace]

It seems that the edit command accepts trailing whitespaces at the end, causing another Bobby Yu, who already exists as a patient to be edited successfully, even though this will be confusing to the user, making it difficult to differentiate patients by name.

image.png

nus-pe-bot commented 2 years ago

Team's Response

This is an intended feature. As a clinic, it is possible that 2 patients may have the same exact name as it is not uncommon for 2 people to have the exact same name. Hence, we allow adding 2 different people with the same name. Furthermore, in this case, even though the 2 people have the same name, they have different emails and phone numbers, clearly indicating that they are 2 different people. It is also clearly stated in the UG what constitutes a duplicate person.

2021-11-14 17.25.29.jpg

By not allowing adding of patients with the same name, the usefulness of the app would be diminished.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Considering the team's response, I think this is a feature flaw.

The current way that the app uses to differentiate patients using 3 fields - phone, email and name seems unrealistic for busy clinic receptionists.

It is quite unlikely that patient's names are duplicates, considering most clinics today still use names as the main way of differentiating patients - because that is usually distinct and much easier to remember than phones and email addresses of individual patients.

As such, if a receptionist wants to edit details of a particular patient, it is more intuitive to just find the name in the list, compared to look up a for unique set of phone, email and name - manually checking for these 3 fields to identify a specific patient is quite inefficient for receptionists - especially considering the find command only supports finding names.


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: Edit is a frequently used command in the app, and I think finding the specific patient to edit by not just filtering the name, but also ensuring that the phone and email indeed belongs to the patient they would like to update - seems time-consuming and unintuitive for busy receptionists, particularly if there are a significant number of patients.