search

amzhy / pe

0 stars 0 forks source link

Edit command gives a misleading output when existing level is the same as the updated level #5

Open amzhy opened 2 years ago

amzhy commented 2 years ago

Steps to reproduce:

  1. edit 1 p/91234567 risk/low

(risk/low works successfully from a previous bug.) This command misinforms the user that the details are updated even thought he existing values are not different from the values in the cmd. It should inform the user that the details are up-to-date perhaps. This could even be a Medium level bug as it might be misguiding to users who might forget that they have already updated a patient's details.

image.png

nus-pe-bot commented 2 years ago

Team's Response

The intended behaviour is achieved by the user, thus this is not a bug. If the user wants to change a patient's details, it shouldn't matter what the patient details currently are.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I disagree, the edit command is only meaningful if the values of the patient are actually updated.

If the new values are the same as the original values, then the edit command is effectively not useful.

In this case, the message conveyed to the user is not accurate and actually allows empty edits to pass successfully. The user would think that she updated the details, when in fact they were already up-to-date. A more useful message should remind the busy receptionist that the details are up-to-date - preventing her from making unnecessary empty edits to the patients in the future.