search

amzn / amazon-pay-api-sdk-dotnet

Amazon Pay API SDK (.NET)
Apache License 2.0
18 stars 8 forks source link

Add support for payment softDescriptor #7

Closed kendallb closed 3 years ago

kendallb commented 3 years ago

This is missing from the API, but it is documented and works.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

bjguillot commented 3 years ago

Can you comment on why you added a new .gitignore file in that subdirectory versus adding the file you want to ignore in the project root .gitignore file?

bjguillot commented 3 years ago

Thanks for your contribution.

kendallb commented 3 years ago

Just toss my ignore file. I did that to ignore the key file I put in there and forget it would show up in the PR. Should have done the PR in a branch to avoid that.

Not sure how you guys manage the key file on your end, since you must have it to build the official packages, but perhaps it does make sense to have it in the root .gitignore file?