amzn / amazon-pay-sdk-csharp

Amazon Pay C# SDK
https://payments.amazon.com/developer
Apache License 2.0
48 stars 42 forks source link

Nuget assembly strong name missing #22

Closed four-bytes-robby closed 5 years ago

four-bytes-robby commented 5 years ago

Current version (3.5.0) of the nuget package has no strong name support as well as 3.4.3.2.

Version 3.4.3.1 has a strong name/is signed.

When a project is depending on the nuget package which is signed amazon pay will not work.

It would be amazing if this could be fixed.

bjguillot commented 5 years ago

Thank you for bringing this to our attention. We are looking into this.

four-bytes-robby commented 5 years ago

No update so far? What about the PSD2 update? Will this happen to this sdk as well? Dead line is 14th of September, Amazon send us an information about the update which should be integrated already June 30th.

bjguillot commented 5 years ago

We're doing internal testing on the 3.5.1 release right now. One of my teammates will be posting it once all the tests pass.

For PSD2-related changes, we call that SCA: Strong Customer Authentication. The 3.5.0 release added new setters on the ConfirmOrderReference method. The 3.5.1 release will add a getter on GetOrderReferenceDetails that is also needed for SCA, though you can always access any new fields from responses that don't yet have getters by using this SDK's Dictionary response. Those attribute names are mentioned in the SCA Integration Guide (For others reading this comment, SCA changes are related to merchants in Europe and UK regions only.)

bjguillot commented 5 years ago

The 3.5.1 release is now published to GitHub and NuGet:

If this fixes your problem, please close the issue.

bjguillot commented 5 years ago

Haven't heard anything in a few weeks, so assuming this issue was resolved in the 3.5.1 release.

four-bytes-robby commented 5 years ago

Will confirm if it has been solved later. Other things were in focus and I may have missed the github notification about the answer.

four-bytes-robby commented 5 years ago

Obviously seems to work :)