amzn / amazon-pay-sdk-java

Amazon Pay Java SDK
https://pay.amazon.com/documentation
Apache License 2.0
58 stars 51 forks source link

adjusted pom for new package name and better scoping of dependencies #7

Closed danielneu closed 8 years ago

hyandell commented 8 years ago

Happened to notice this, thought I'd offer feedback.

Not sure if there's much value moving the versions into properties. If you had a multiproject with a parent pom, then it's a useful way to stay on the same version across the submodules, but with just the one pom file it seems to introduce the pain of having to look in two places for the relevant information to a dependency.

danielneu commented 8 years ago

Kind of agree, although I in this case would additionally go for depencyManagement.

The advantage I see here is, if you have two dependencies that rely on the same version, like powermock. If you don't like it, feel free to change it.

But my main goal of this change was to: