amzn / amazon-payments-magento-2-plugin

Extension to enable Amazon Pay on Magento 2
https://amzn.github.io/amazon-payments-magento-2-plugin/
Apache License 2.0
109 stars 77 forks source link

Magento Swagger crashes due to parameter notation in API interface #1078

Closed ebaschiera closed 3 years ago

ebaschiera commented 3 years ago

Hi, it looks like a parameter type notation in https://github.com/amzn/amazon-payments-magento-2-plugin/blob/master/Api/CheckoutSessionManagementInterface.php doesn't get along with Magento Swagger. I don't know if anything else is crashing too, but a Swagger crash is a blocker when working with APIs.

The fix is very simple and I am providing a PR.

Thanks!

What I expected

What happened instead

Steps to reproduce the issue

Open Magento Swagger UI, by visiting http:///swagger See that it reports the following error message: Internal Server Error https://<magento_url>/rest/all/schema?services=all

Your setup

sgabhart22 commented 3 years ago

Hello @ebaschiera ,

Thanks for picking up on this and providing the PR! We're currently testing this internally and initially all looks good. Once our QA passes, we'll include the fix in our workflow to go out in the next release. For now we'll close the PR without accepting it, but this issue will remain open until the release goes out.

zichicc commented 3 years ago

Hi @ebaschiera ,

thanks for your contribution. The new release has been published: https://marketplace.magento.com/amzn-amazon-pay-magento-2-module.html

Thanks best

Christian

ebaschiera commented 3 years ago

Thanks!