amzn / amazon-payments-magento-2-plugin

Extension to enable Amazon Pay on Magento 2
https://amzn.github.io/amazon-payments-magento-2-plugin/
Apache License 2.0
109 stars 77 forks source link

Amazon_Pay/js/amazon-product-add.min.js 404 (Not Found) #1240

Closed tim-breitenstein-it closed 5 months ago

tim-breitenstein-it commented 5 months ago

What I expected

Working PDP.

What happened instead

Browser Console shows Error:

 https://m246.example.com/static/versionXYZ/frontend/Test/Theme/Amazon_Pay/js/amazon-product-add.min.js net::ERR_ABORTED 404 (Not Found)

Steps to reproduce the issue

Your setup

I think it is related to this Commit: https://github.com/amzn/amazon-payments-magento-2-plugin/commit/48e5bea0d81ca829948b33b74f8111cbb1177bed

The view/frontend/web/js/amazon-product-add.js file is removed but still exists in requirejs-config.js map section in v5.17.0!

sgabhart22 commented 5 months ago

Thanks @tim-breitenstein-it ! We'll look to get this folded into the 5.17.1 patch release. I saw you opened a PR for the fix; FYI, we won't merge that into the repo directly, but will cherry pick your commit into the next release branch to retain the author information.

Thanks again, Spencer

sgabhart22 commented 5 months ago

Hi @tim-breitenstein-it ,

5.17.1 is now live on the Marketplace! We'll go ahead and close this issue, but feel free to open any new issues or PRs for future problems. Thanks again!

Spencer