Upgrade to exoplayer r2.11.4

amzn / exoplayer-amazon-port

Official port of ExoPlayer for Amazon devices

Apache License 2.0

173 stars 80 forks source link

Upgrade to exoplayer r2.11.4 #103

Closed NicolaVerbeeck closed 4 years ago

NicolaVerbeeck commented 4 years ago

Any timeline for the upgrade to latest exoplayer release? We are dependant on some new functionality released there

rinoshs commented 4 years ago

Which specific functionality in r2.11.4 is required?

NicolaVerbeeck commented 4 years ago

Catch and log exceptions in TextRenderer rather than re-throwing. This allows playback to continue even if subtitle decoding fails (#6885).
Update the manifest URI to avoid repeated HTTP redirects (#6907).
Parse period AssetIdentifier elements.

NicolaVerbeeck commented 4 years ago

Any news on this? In the meanwhile exoplayer has released 2.11.5

aureobeck commented 4 years ago

We are interested in these updates as well, there was substantial changes on the latest versions of Exoplayer, if you could please give some feedbacks when this should be updated, it's on 2.11.7 already, thanks!

NicolaVerbeeck commented 4 years ago

Given that we can no longer wait, I took a diff from the amazon changes in 2.11.3 and applied these on top of exoplayer 2.11.7. Commit -> https://github.com/icapps/exoplayer-icapps-port/commit/a17c122191ee13aabe111a9744802430740635cf These changes have not been verified yet

jkwiz commented 4 years ago

@rinoshs r2.11.5 has a crash fix affecting some devices.

https://github.com/google/ExoPlayer/issues/7234

lwld commented 4 years ago

In the meantime there's ExoPlayer 2.12.0 on Google, would suggest to update directly there. (see #107)

rinoshs commented 4 years ago

Will combine and track with isssue #107

https://github.com/amzn/exoplayer-amazon-port/issues/107