Closed kaakaa closed 7 years ago
Thank you Yusuke :) The English looks pretty good; much better than my Japanese (I'm just starting to try and learn... "my name is" and how to write a i e o u in hiragana :) ).
I'm clueless on docker, so I'll try to follow the readme and see if it works for me. Also other members of the open source team at amazon have been using docker for others of our project, so I'll have them weigh in with more intelligent thoughts ( @jpeddicord + @jamesiri ).
Dockerfile looks great ๐
Long-term it'd be nice to remove postgresql and use that container directly, perhaps via stack/compose file. But this PR should work fine for getting started.
@hyandell
Your challenge to start learning Japanese is sounds great to me!
(It may be not a i e o u
and be a i u e o
๐ )
I will be welcoming for your reply in Japanese ๐.
And I found a little mistakes in README.md, so I will be fixing it soon.
@jpeddicord Thank you for your reviewing. I think so too. At first I tried to write docker-compose.yml. oss-dashboard/docker-compose.yml at docker ยท kaakaa/oss-dashboard
But I thought that it has some complexity to add Docker and docker-compose.yml at same time. So after merged this PR, I'll send next PR about docker-compsoe.
I think we should move to the separate postgresql container, but first I'm going to merge this, fix a couple of typos and mark it as experimental.
Doumo osoreirimasu gozaimashita, Yusuke-san :)
I forgot to ask this - could you confirm that this contribution is under the Apache License, 2.0?
Dou itashimashite, Henri-san ๐ (meaning Not at all, Mr. Henri!
)
Thank you for merging!
And yes, I confirm that my patches are under the Apache License 2.0.
Merged :)
fixes #74
I have written dockerfile for oss-dashboard and how to run oss-dashboard docker container. But my English in README.md may be wrong, so please point it out or fix it.