search

amzn / pecos

PECOS - Prediction for Enormous and Correlated Spaces
https://libpecos.org/
Apache License 2.0
517 stars 105 forks source link

pin setuptools version to 73.0.1 #298

Closed vpung closed 2 months ago

vpung commented 2 months ago

Issue #, if available: N/A

Description of changes: Pin the version of setuptools to be 73.0.1. The latest version of setuptools is 74.0.0 and Github workflow fails with message:

ModuleNotFoundError: No module named 'distutils.msvccompiler'

According to the release notes of setuptools, distutils has been deprecated. Reading from the Numpy docs, distutils also is marked as deprecated. The solution provided is to temporarily pin down the version of setuptools to the last known working version of our build which is version 73.0.1.

Testing the pin down version of setuptools, we get the following error: ERROR: Some build dependencies for file:///home/ec2-user/pecos conflict with the backend dependencies: setuptools==74.0.0 is incompatible with setuptools<=73.0.1. We pin down pip to the highest version possible without getting this error which is pip==23.0.1.

Pinning down setuptools and pip is temporary and the following weeks, we should move away from distutils and revert these changes.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

weiliw-amz commented 2 months ago

Could you provide references links for ongoing issue that new release of setuptools==74.0.0 breaks numpy installation, so as a dependency, we have to pin down to old version until a fix is made?

Also, we need a TODO tag and comments for reason around these temp fixing lines for reminder.