amzn / selling-partner-api-models

This repository contains OpenAPI models for developers to use when developing software to call Selling Partner APIs.
Apache License 2.0
590 stars 728 forks source link

Incomplete enum list for FulfillmentInbound ShipmentStatus in fulfillmentInboundV0.json #270

Closed jasonhebert closed 4 months ago

jasonhebert commented 2 years ago

Please update the fulfillmentInboundV0.json model file to include undocumented ShipmentStatus value READY_TO_SHIP.

In the fulfilment-inbound-api-v0-model file it lists the following accepted values for the ShipmentStatus enum:

[
        "WORKING",
        "SHIPPED",
        "RECEIVING",
        "CANCELLED",
        "DELETED",
        "CLOSED",
        "ERROR",
        "IN_TRANSIT",
        "DELIVERED",
        "CHECKED_IN"
]

An additional value of READY_TO_SHIP is also returned from the API as shown here:

{
    "payload":
    {
        "ShipmentData":
        [
            {
                "ShipmentId": "FBA********C",
                "ShipmentName": "FBA **********",
                "ShipFromAddress":
                {
                    "Name": "Tian******",
                    "AddressLine1": "******",
                    "DistrictOrCounty": "Na******",
                    "City": "Hu******",
                    "StateOrProvinceCode": "T******",
                    "CountryCode": "**",
                    "PostalCode": "*****"
                },
                "DestinationFulfillmentCenterId": "ONT8",
                "ShipmentStatus": "READY_TO_SHIP",
                "LabelPrepType": "SELLER_LABEL",
                "BoxContentsSource": "INTERACTIVE"
            }
        ]
    }
}
Proladge commented 1 year ago

@jasonhebert , could the issue be closed?

jasonhebert commented 1 year ago

I received email response on another ticket in a different ticketing system for Amazon that the READY_TO_SHIP status should not be returned from the API. Nothing since then so I am not sure if the issue has been resolved or not. No official word from any Amazon devs on this issue.

jasonhebert commented 1 year ago

Prior response from other ticket: "I am afraid that there is no current time line, however it is likely that the resolution will be to stop READY_TO_SHIP being issued as a shipment status, since there is no user value to it in terms of the FBA shipping API. Instead, it is likely that this will be mapped to WORKING as this is the least complicated resolution. I will follow up as soon as additional information becomes available."

Received a response just now that the READY_TO_SHIP status is in fact a good status to be returned and the model documentation and swagger docs have now been updated to include the status.

UGH!!!

clayton-k commented 1 year ago

Hello @jasonhebert, I think the READY_TO_SHIP status has not been added to the model document: https://github.com/amzn/selling-partner-api-models/blob/main/models/fulfillment-inbound-api-model/fulfillmentInboundV0.json#L6168

jasonhebert commented 1 year ago

They added it to the getShipments operation as an input value for the ShipmentStatusList parameter but I now see that they have NOT added it to the actual enum that is returned from the operation. Dealing with them on this has been a total nightmare and no-one knows what is going on. It seems there are multiple teams working on this and they have no clue what each is doing. I've received multiple different responses from multiple people over 4 tickets I've filed, nothing has actually been done except this change, and it is incorrect as well it seems.

Would someone else like to take this on? I'm tired boss, so tired.

github-actions[bot] commented 5 months ago

This is a very old issue that is probably not getting as much attention as it deserves. We encourage you to check if this is still an issue after the latest release and if you find that this is still a problem, please feel free to open a new issue and make a reference to this one.

github-actions[bot] commented 4 months ago

closed for inactivity