amzn / selling-partner-api-models

This repository contains OpenAPI models for developers to use when developing software to call Selling Partner APIs.
Apache License 2.0
612 stars 736 forks source link

Product Pricing -> OfferDetailList -> SubCondition case not same as documentation #2902

Closed damianelder closed 1 year ago

damianelder commented 2 years ago

https://developer-docs.amazon.com/sp-api/docs/product-pricing-api-v0-reference#offerdetaillist

The subcondition of the item. Subcondition values: New, Mint, Very Good, Good, Acceptable, Poor, Club, OEM, Warranty, Refurbished Warranty, Refurbished, Open Box, or Other.

actual output from API is not the same case per documentation, Item condition is sentence case as was MWS responses for same. we can work around this for "Subcondition" but would be good to update docs with the correct case for "Subcondition".

image

x-amzn-RequestId: 96e6e003-3db7-469c-9778-a246358d5a7c

"responses":[ { "status":{ "statusCode":200, "reasonPhrase":"OK" }, "body":{ "payload":{ "SKU":"DAMO-BOOK-TEST-1", "status":"Success", "ItemCondition":"New", "Identifier":{ "MarketplaceId":"A1F83G8C2ARO7P", "ItemCondition":"New", "SellerSKU":"DAMO-BOOK-TEST-1" }, "Summary":{ "LowestPrices":[ { "condition":"used", "fulfillmentChannel":"Merchant", "LandedPrice":{ "CurrencyCode":"GBP", "Amount":29.98 }, "ListingPrice":{ "CurrencyCode":"GBP", "Amount":26.99 }, "Shipping":{ "CurrencyCode":"GBP", "Amount":2.99 } }, { "condition":"new", "fulfillmentChannel":"Amazon", "LandedPrice":{ "CurrencyCode":"GBP", "Amount":25.59 }, "ListingPrice":{ "CurrencyCode":"GBP", "Amount":25.59 }, "Shipping":{ "CurrencyCode":"GBP", "Amount":0 } }, { "condition":"new", "fulfillmentChannel":"Merchant", "LandedPrice":{ "CurrencyCode":"GBP", "Amount":24.42 }, "ListingPrice":{ "CurrencyCode":"GBP", "Amount":24.42 }, "Shipping":{ "CurrencyCode":"GBP", "Amount":0 } } ], "BuyBoxPrices":[ { "condition":"new", "LandedPrice":{ "CurrencyCode":"GBP", "Amount":25.59 }, "ListingPrice":{ "CurrencyCode":"GBP", "Amount":25.59 }, "Shipping":{ "CurrencyCode":"GBP", "Amount":0 } } ], "NumberOfOffers":[ { "condition":"used", "fulfillmentChannel":"Merchant", "OfferCount":3 }, { "condition":"new", "fulfillmentChannel":"Amazon", "OfferCount":1 }, { "condition":"new", "fulfillmentChannel":"Merchant", "OfferCount":6 } ], "BuyBoxEligibleOffers":[ { "condition":"used", "fulfillmentChannel":"Merchant" }, { "condition":"new", "fulfillmentChannel":"Amazon" }, { "condition":"new", "fulfillmentChannel":"Merchant" } ], "SalesRankings":[ { "ProductCategoryId":"book_display_on_website", "Rank":209630 }, { "ProductCategoryId":"275035", "Rank":14654 }, { "ProductCategoryId":"270419", "Rank":33463 } ], "ListPrice":{ "CurrencyCode":"USD", "Amount":29.97 }, "TotalOfferCount":10 }, "Offers":[ { "Shipping":{ "CurrencyCode":"GBP", "Amount":0 }, "ListingPrice":{ "CurrencyCode":"GBP", "Amount":24.42 }, "ShippingTime":{ "maximumHours":48, "minimumHours":24, "availabilityType":"NOW" }, "SellerFeedbackRating":{ "FeedbackCount":99, "SellerPositiveFeedbackRating":94 }, "ShipsFrom":{ "Country":"GB" }, "PrimeInformation":{ "IsPrime":false, "IsNationalPrime":false }, "SubCondition":"new", "SellerId":"A2LEVSV8WYZNG7", "IsFeaturedMerchant":true, "IsBuyBoxWinner":false, "MyOffer":false, "IsFulfilledByAmazon":false }, { "Shipping":{ "CurrencyCode":"GBP", "Amount":0 }, "ListingPrice":{ "CurrencyCode":"GBP", "Amount":25.37 }, "ShippingTime":{ "maximumHours":360, "minimumHours":264, "availabilityType":"NOW" }, "SellerFeedbackRating":{ "FeedbackCount":4061304, "SellerPositiveFeedbackRating":93 }, "ShipsFrom":{ "Country":"GB" }, "PrimeInformation":{ "IsPrime":false, "IsNationalPrime":false }, "SubCondition":"new", "SellerId":"AHRB2OK2Q2YCL", "IsFeaturedMerchant":true, "IsBuyBoxWinner":false, "MyOffer":false, "IsFulfilledByAmazon":false }, { "Shipping":{ "CurrencyCode":"GBP", "Amount":0 }, "ListingPrice":{ "CurrencyCode":"GBP", "Amount":25.59 }, "ShippingTime":{ "maximumHours":0, "minimumHours":0, "availabilityType":"NOW" }, "PrimeInformation":{ "IsPrime":true, "IsNationalPrime":true }, "SubCondition":"new", "SellerId":"A3P5ROKL5A1OLE", "IsFeaturedMerchant":true, "IsBuyBoxWinner":true, "MyOffer":false, "IsFulfilledByAmazon":true }, { "Shipping":{ "CurrencyCode":"GBP", "Amount":0 }, "ListingPrice":{ "CurrencyCode":"GBP", "Amount":28.55 }, "ShippingTime":{ "maximumHours":48, "minimumHours":24, "availabilityType":"NOW" }, "SellerFeedbackRating":{ "FeedbackCount":4395, "SellerPositiveFeedbackRating":88 }, "PrimeInformation":{ "IsPrime":false, "IsNationalPrime":false }, "SubCondition":"new", "SellerId":"ABOJSES0S2DJ2", "IsFeaturedMerchant":true, "IsBuyBoxWinner":false, "MyOffer":false, "IsFulfilledByAmazon":false }, { "Shipping":{ "CurrencyCode":"GBP", "Amount":0 }, "ListingPrice":{ "CurrencyCode":"GBP", "Amount":37.2 }, "ShippingTime":{ "maximumHours":24, "minimumHours":24, "availabilityType":"NOW" }, "SellerFeedbackRating":{ "FeedbackCount":28, "SellerPositiveFeedbackRating":100 }, "ShipsFrom":{ "Country":"GB" }, "PrimeInformation":{ "IsPrime":false, "IsNationalPrime":false }, "SubCondition":"new", "SellerId":"A3EMO9TIVUXSFN", "IsFeaturedMerchant":false, "IsBuyBoxWinner":false, "MyOffer":true, "IsFulfilledByAmazon":false }, { "Shipping":{ "CurrencyCode":"GBP", "Amount":17.76 }, "ListingPrice":{ "CurrencyCode":"GBP", "Amount":27.53 }, "ShippingTime":{ "maximumHours":240, "minimumHours":144, "availabilityType":"NOW" }, "SellerFeedbackRating":{ "FeedbackCount":13585, "SellerPositiveFeedbackRating":93 }, "ShipsFrom":{ "Country":"US" }, "PrimeInformation":{ "IsPrime":false, "IsNationalPrime":false }, "SubCondition":"new", "SellerId":"A9MGRJLU8P3U5", "IsFeaturedMerchant":true, "IsBuyBoxWinner":false, "MyOffer":false, "IsFulfilledByAmazon":false }, { "Shipping":{ "CurrencyCode":"GBP", "Amount":7.43 }, "ListingPrice":{ "CurrencyCode":"GBP", "Amount":41.66 }, "ShippingTime":{ "maximumHours":48, "minimumHours":24, "availabilityType":"NOW" }, "SellerFeedbackRating":{ "FeedbackCount":233, "SellerPositiveFeedbackRating":83 }, "ShipsFrom":{ "Country":"US" }, "PrimeInformation":{ "IsPrime":false, "IsNationalPrime":false }, "SubCondition":"new", "SellerId":"A14NWB76D5UAFY", "IsFeaturedMerchant":true, "IsBuyBoxWinner":false, "MyOffer":false, "IsFulfilledByAmazon":false } ], "marketplaceId":"A1F83G8C2ARO7P" } }, "headers":{ "x-amzn-RequestId":"cd5ce609-9a66-43b2-ad2b-376f44376a7f", "Date":"Wed, 31 Aug 2022 11:01:35 GMT" }, "request":{ "MarketplaceId":"A1F83G8C2ARO7P", "SellerSKU":"DAMO-BOOK-TEST-1", "CustomerType":"Consumer", "ItemCondition":"New" } } ] }

bigindian66 commented 2 years ago

To make an addition to this bug report : The "getPricing" route does return the values in a sort of CamelCase as shown in the doc. (Well... Almost. e.g. : Very Good => VeryGood) Whereas the "getCompetitivePricing" returns snake_case

["sub_condition"]=>
              string(9) "very_good"

It would be nice to have more consistency inside the ProductPricing API (at least).

Thanks !

damianelder commented 2 years ago

☹️ thanks for the heads up on "getCompetitivePricing" one👍

github-actions[bot] commented 1 year ago

This is a very old issue that is probably not getting as much attention as it deserves. We encourage you to check if this is still an issue after the latest release and if you find that this is still a problem, please feel free to open a new issue and make a reference to this one.

github-actions[bot] commented 1 year ago

closed for inactivity