amzn / selling-partner-api-models

This repository contains OpenAPI models for developers to use when developing software to call Selling Partner APIs.
Apache License 2.0
545 stars 722 forks source link

Freakish whitespace in SP-API JSON responses #535

Open johnkw opened 4 months ago

johnkw commented 4 months ago

This has bothered me for years but I held back on filing a bug report. This affects most (or all?) API responses. But just for example here's the response from testing bug amzn/selling-partner-api-models#370:

b'\n{\n\n\t\n\t\t\t\t\t\t"payload": {\n\t\t\t\n\t\t\t\t\t\t\t\t\t\t\t\t\t\t"ShipmentData":\n\t\t\t\t[\n\t\t\t\t\t\t\t\t]\n\t\t\t\t\t\t\t\n\t\t\t\t\t\t\t\t}\n\t\t\t}\n\n'

It's hilarious how it alternates back and forth between linefeeds and tabs, without ever outputting actual data.

This may not violate any JSON protocol, but it makes debug logs difficult to read for no reason.

github-actions[bot] commented 1 month ago

This is a very old issue that is probably not getting as much attention as it deserves. We encourage you to check if this is still an issue after the latest release and if you find that this is still a problem, please feel free to open a new issue and make a reference to this one.

johnkw commented 1 month ago

Can confirm this is still broken.

github-actions[bot] commented 2 weeks ago

This is a very old issue that is probably not getting as much attention as it deserves. We encourage you to check if this is still an issue after the latest release and if you find that this is still a problem, please feel free to open a new issue and make a reference to this one.

johnkw commented 2 weeks ago

This should not be closed. It could be converted to a "discussion" since that's apparently where bug reports go now.