search

amzn / smoke-aws

AWS services integration for the Smoke Framework
Apache License 2.0
111 stars 19 forks source link

AWS API fails because lower case codingkeys #10

Closed joscdk closed 3 years ago

joscdk commented 5 years ago

When launching an instance, a lot of nested keys fails. There are some examples here:

deleteOnTermination should have `= "DeleteOnTermination" https://github.com/amzn/smoke-aws/blob/0.16.9/Sources/ElasticComputeCloudModel/ElasticComputeCloudModelStructures.swift#L11575

deviceName should have = "DeviceName" https://github.com/amzn/smoke-aws/blob/0.16.9/Sources/ElasticComputeCloudModel/ElasticComputeCloudModelStructures.swift#L1394

There are more, however here are a couple of examples.

tachyonics commented 5 years ago

Thanks for opening this issue. I'll take a look at it.

tachyonics commented 5 years ago

It looks like this is due to a deviation between the published model[1] and the API Reference[2]. Looks like it is consistent for the EC2 service so I think there is a straight forward path forward to capitalise all request keys.

I will verify with the runInstances API.

[1] https://github.com/aws/aws-sdk-go/blob/master/models/apis/ec2/2016-11-15/api-2.json#L19335-L19337 [2] https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_BlockDeviceMapping.html

tachyonics commented 5 years ago

I have been able to reproduce the issue and identify a fix that I have been able to test by starting an instance with an attached Ebs volume. There are changes across SmokeHTTP and SmokeAWS. I have just published the pull request for SmokeHTTP.

joscdk commented 5 years ago

@tachyonics sweet, thank you very much, then i can switch away from my own hacked fork :D .. I might give it a go if i find some free time tonight :)

tachyonics commented 5 years ago

@joscdk The changes to this package are now pushed to the fix_query_errors_ec2_keys branch. Let me know if you are still having issues.

tachyonics commented 5 years ago

@joscdk Were you able to verify that this fixed your issue?

joscdk commented 5 years ago

@tachyonics no sorry, we have had an insanely tight deadline on our project, so i am still using my own fork for this and 18.04 support .. I will see if i can try to switch it out during the weekend as a test :)

tachyonics commented 3 years ago

Closing this issue has its long been fixed in the codebase and we were waiting on verification of fix.