amzn / smoke-aws

AWS services integration for the Smoke Framework
Apache License 2.0
111 stars 19 forks source link

Pre-release identifiers #41

Closed tanner0101 closed 4 years ago

tanner0101 commented 4 years ago

I'm running into some strange SPM errors when using .branch("2.25.35.alpha.1"). These go away if I specify a specific revision. In this case, .revision("43b6b5..."). I think this is due to how SPM treats branches differently than revisions or tagged versions.

If this package used standardized semver pre-release identifiers, then people be able to depend on alpha versions without using .branch. For example, if the release were tagged as 2.0.0-alpha.1, one could do:

.package(url: "https://github.com/amzn/smoke-aws.git", from: "2.0.0-alpha")

This has the added benefit of automatically opting into later alphas, betas, and the final release when one does swift package update.

tachyonics commented 4 years ago

Thanks @tanner0101, I didn't realise SPM supported pre-release tags this way. I have tagged a 2.0.0-alpha.2 version. Let me know if you need anything else or have any issues.

tanner0101 commented 4 years ago

@tachyonics thanks! That fixed my issue.