Add integration/pull request CI testing for Smoke Framework

amzn / smoke-framework

A light-weight server-side service framework written in the Swift programming language.

Apache License 2.0

1.45k stars 41 forks source link

Add integration/pull request CI testing for Smoke Framework #10

Closed tachyonics closed 5 years ago

tachyonics commented 6 years ago

Description

Add integration tests for the framework

Exit criteria

The integration tests should-

pull the latest version of the code or the pull request being submitted
build the code, run tests and SwiftLint
Build the change into an example application, make sure application compiles and starts up
Hit an endpoint on the sample application and verify expected result was returned.

meguid commented 5 years ago

@tachyonics I'm interested to help in this.

tachyonics commented 5 years ago

@meguid Thanks for the help. I'd be interested in any thoughts you have on the best approach. I was thinking of suggesting going with AWS CodeBuild as that is what I know but I'd be happy to look at other options.

meguid commented 5 years ago

@tachyonics I'm not familiar with CodeBuild, but I think Travis CI have better community support and free for open source projects.

tachyonics commented 5 years ago

Sorry for taking so long for getting back on this. Looks like Travis CI is the better option. I have requested that it be installed on our repositories and then we can set it up.

meguid commented 5 years ago

No problem, that's great. I'm ready.

On Wed, Dec 5, 2018 at 3:52 PM tachyonics notifications@github.com wrote:

Sorry for taking so long for getting back on this. Looks like Travis CI is the better option. I have requested that it be installed on our repositories and then we can set it up.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/amzn/smoke-framework/issues/10#issuecomment-444492069, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ3lVQ9wpC8F6Zd5e70maIhz5_lzZ1Vcks5u18-egaJpZM4YAWvN .

tachyonics commented 5 years ago

Thanks. I've added a basic CI integration that compiles and runs the tests and SwiftLint to confirm that it is working. If you'd like to look at what else can be added that would be great!

meguid commented 5 years ago

I checked the CITests script and the travis file and I see they're great.

I think it'd be better if we applied a test coverage minimum percentage on code, and also I think it'd be better if we limited the "disabled_rules" a bit in Swiftlint and installed it in an "install" step in travis not in the "run" script.

tachyonics commented 5 years ago

Those sound good ideas. Is there anything you need from me to look further into this?