Package.swift does not contain all dependencies

amzn / smoke-framework

A light-weight server-side service framework written in the Swift programming language.

Apache License 2.0

1.45k stars 41 forks source link

Package.swift does not contain all dependencies #62

Open PeterAdams-A opened 4 years ago

PeterAdams-A commented 4 years ago

Some versions of swift package manager react badly to missing dependencies in the swift package file.

For example -

SmokeHTTP1 uses SmokeOperations (here https://github.com/amzn/smoke-framework/blob/main/Sources/SmokeHTTP1/ChannelHTTP1ResponseHandler.swift#L21)

but there is no declared dependency (here https://github.com/amzn/smoke-framework/blob/db1332849a16575cb71426ccfbc2065d2f0c3352/Package.swift#L59-L65)

tachyonics commented 4 years ago

Hi Peter, sorry for the delay. Looks like this was a miss. Is there any systematic way to detect such issues and any other instances where this has happened?

Thanks, Simon

Davidde94 commented 3 years ago

@tachyonics Swift Package Manager are working on a fix, tracked here https://bugs.swift.org/browse/SR-1393