search

amzn / smoke-http

Specialised HTTP Client for service operations abstracted from the HTTP protocol.
Apache License 2.0
71 stars 15 forks source link

Revert off-task async executor #116

Closed tachyonics closed 1 year ago

tachyonics commented 1 year ago

Issue #, if available:

Description of changes:

  1. Revert off task async executor: Further load testing has identified this is not beneficial to performance (optimizations elsewhere - such as logging - have had greater impact)
  2. For the retriable async/await APIs, don't pass a specific eventLoop to async-http-client: EventLoop affinity here doesn't have any benefit and investigation into AHC shows the http connection reuse is more optimised when an EventLoop is not passed in.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.