Move ELG shutdown to an explicit shutdown call

amzn / smoke-http

Specialised HTTP Client for service operations abstracted from the HTTP protocol.

Apache License 2.0

71 stars 15 forks source link

Move ELG shutdown to an explicit shutdown call #3

Closed tachyonics closed 5 years ago

tachyonics commented 6 years ago

Move eventLoopGroup.syncShutdownGracefully() to an explicit shutdown call in HTTPClient to avoid this call in deinit as this is dangerous and could cause a deadlock or crash (This suggestion has come from the SwiftNIO team).

Exit criteria

Create an explicit shutdown API on HTTPClient to close the client.
Check in deinit if this shutdown API has been called otherwise log an error or fatal (determine which is appropriate)

tachyonics commented 5 years ago

The change for this issue has been merged to master. deinit logs an error if the client wasn't closed.