chore(deps): Migrate from node-sass to dart-sass

amzn / style-dictionary

A build system for creating cross-platform styles.

https://styledictionary.com

Apache License 2.0

3.87k stars 543 forks source link

Closed arnaud-ritti closed 2 months ago

arnaud-ritti commented 12 months ago

Description of changes:

Migrate from the deprecated node-sass to dart-sass

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

notbear commented 8 months ago

Hi @dbanksdesign

Any chance for reviewing this in a predictable time? Would appreciate it a lot.

jorenbroekema commented 8 months ago

Hey, I actually migrated to dart-sass already in the v4 branch, which is released as a prerelease already.

Two questions:

Can you use the v4 prerelease for your use case? If not, can you explain why you need to have this change in v3, what exactly is making it blocking for you?
The cssEscape utility, can you explain what it does and why it's needed, and perhaps add some tests to document this? I don't have this part of your changes in the v4 branch yet, the rest of it (tests mostly) I do

jorenbroekema commented 2 months ago

v4 is stable and merged to main by now, so closing this as fixed in v4