fix: added missing types to TokenFormatterArgs

amzn / style-dictionary

A build system for creating cross-platform styles.

https://styledictionary.com

Apache License 2.0

3.93k stars 557 forks source link

fix: added missing types to TokenFormatterArgs #1024

Closed markusnissl closed 10 months ago

markusnissl commented 1 year ago

Issue #, if available: no issue found

Description of changes: createPropertyFormatter supports more options currently than provided via typescript types. I added these variables to the type.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

jorenbroekema commented 10 months ago

FYI this is also fixed in the v4 branch, you could already use the v4 prereleases if you like.

I think for now we keep v3 as is, only fixing important bugs or security vulnerabilities. This type issue falls in the category of minor bug, so since it's usually quite easily possible to work around it I'd like to close the PR.