fix: outputReferenceFallbacks for css/variables formatter

amzn / style-dictionary

A build system for creating cross-platform styles.

https://styledictionary.com

Apache License 2.0

3.87k stars 543 forks source link

fix: outputReferenceFallbacks for css/variables formatter #1112

Closed tkgroot closed 2 months ago

tkgroot commented 7 months ago

Issue #, if available:

If options were provided with outputReferences and outputReferenceFallbacks set to true did not add the fallbacks when running with the css/variables formatter.

Description of changes:

outputReferenceFallbacks options are passed through to up until the createPropertyFormatter function, which was previously not the case
add test to verify outputReferenceFallbacks are set
update test snapshot

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

tkgroot commented 7 months ago

created a PR for the new v4 version as well. it can be found here #1113

jorenbroekema commented 6 months ago

Since v3 is essentially in maintenance mode now that v4 is coming soon, I'd prefer to only merge high prio bugfixes/security vulnerabilities, is it okay to only do this fix to the v4 branch?

tkgroot commented 6 months ago

TL;DR: I would appreciate if this bugfix would make it into the current version.

tbh, I find that a bit weird to put v3 in maintenance mode before v4 is actually released. Do not understand the reasoning behind. I will not upgrade my current setup to a running beta because v4 is coming soon (especially because I dislike the term "coming soon"). My current setup does require that bugfix and I'm, like I said, not keen to adapt a beta version.

jorenbroekema commented 6 months ago

Understandable, the main reason is that I'm carrying this solo at the moment and I've got limited time. Since v4 is a complete refactor (ESM, browser-compatible, first-class type safety, and the list goes on), it's getting pretty tough to backport every non-crucial thing to v3. I also don't have CI/CD set up for v3 and thus require @dbanksdesign to manually publish v3, while the v4 prereleases I can publish through github actions myself.

I get your point though about being forced into an unstable API beta version. since this PR is small I'll try to get it released for v3

tkgroot commented 6 months ago

Oh my, I didn't know that this was such a hassle. appreciate the effort you put in to get this released. 💯

jorenbroekema commented 2 months ago

v4 is stable and merged to main by now, so closing this as fixed in v4