amzn / style-dictionary

A build system for creating cross-platform styles.
https://styledictionary.com
Apache License 2.0
3.87k stars 543 forks source link

Version Packages (prerelease) #1190

Closed github-actions[bot] closed 4 months ago

github-actions[bot] commented 4 months ago

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to v4, this PR will be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

v4 is currently in pre mode so this branch has prereleases rather than normal releases. If you want to exit prereleases, run changeset pre exit on v4.

⚠️⚠️⚠️⚠️⚠️⚠️

Releases

style-dictionary@4.0.0-prerelease.28

Minor Changes

Patch Changes

aws-amplify-us-west-1[bot] commented 4 months ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1190.d16eby4ekpss5y.amplifyapp.com

aws-amplify-us-west-1[bot] commented 4 months ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1190.d1ouz7xofr5p4l.amplifyapp.com

SpikyC commented 4 months ago

I know that in CSS, linear-gradient() is not actually a <color>, it’s an <image>. I guess that it’s normal then if it’s not interpreted has a color.

I wonder if tinycolor2 should still be used as it’s a bit outdated and it does not support most recent CSS color syntaxes. I stumbled across a library called Color.js that does support newly introduced syntaxes, you might want to have a look at it.

jorenbroekema commented 4 months ago

Yeah I'm a fan of that library, please raise an issue for migrating to it to support things like oklab/oklch etc, I foresee this becoming more common and I know a couple of color nerds that would love for SD to support it in its transforms (@mikekamminga ). I won't have time for it for v4 but PRs are welcome still, seems to me like it wouldn't be a breaking change if color.js supports everything tinycolor2 does except more.

SpikyC commented 4 months ago

[…] seems to me like it wouldn't be a breaking change if color.js supports everything tinycolor2 does except more.

Unfortunately, I noticed that a few (non-standard) things that tinycolor2 supports are not supported by Color.js. Since the nature of Color.js makes it extensible, there could be some things done to support some of them, but I doubt that everything could be covered.

jorenbroekema commented 4 months ago

[…] seems to me like it wouldn't be a breaking change if color.js supports everything tinycolor2 does except more.

Unfortunately, I noticed that a few (non-standard) things that tinycolor2 supports are not supported by Color.js. Since the nature of Color.js makes it extensible, there could be some things done to support some of them, but I doubt that everything could be covered.

Shall we raise a separate issue for this? Can you share which things are unsupported, we can decide whether we want to add backwards compat or not, I think unprefixed hexadecimals is an example of something we could probably just decide to stop supporting, and folks can always write a custom value transform to put the # in front of such values if they really need them