Open niggeulimann opened 2 months ago
This pull request is automatically being deployed by Amplify Hosting (learn more).
Access this pull request here: https://pr-1331.d16eby4ekpss5y.amplifyapp.com
Thanks for contributing this, I think it makes sense to add both transforms you mentioned and then also have them added to the android transformGroup. The "true"
and "false"
values can be just true and
falseand the filter can check for the
$type/
typeinstead of the
attributes.item/
attributes.subitem`.
I think we need to discuss with @dbanksdesign whether we want to create a new format/transformGroup for these improvements or whether we consider this bugfixes that should be added in a minor patch. Technically speaking changing the format / token value transforms within a transformGroup are breaking changes.
As discussed earlier in the this PR includes two things:
fontFamily
to an android-ressource entry like<item name="typography_body_font_family" type="font">@font/comic_sans_regular</item>
❗️to fully support this, i also use the following transform, which is not included yet
Usage: the value can be used with https://developer.android.com/reference/android/widget/TextView#attr_android:fontFamily - please ensure that the font-file has the same name
textCase
to a bool android ressource like this:<bool name="typography_body_text_case">false</bool>
❗️this also needs a transform:Usage: the generated resource can be used with https://developer.android.com/reference/android/widget/TextView#attr_android:textAllCaps
From our point of view, this would be a big improvement.