search

amzn / style-dictionary

A build system for creating cross-platform styles.
https://styledictionary.com
Apache License 2.0
3.93k stars 557 forks source link

Missing newline at the end of generated file #949

Closed AugustinasVainius closed 1 year ago

AugustinasVainius commented 1 year ago

Good day, some in-built formats produce output which is missing newline at the end of file. Github doesn't like that image as well as it may cause other problems down the line.

The formats I've encountered this problem with: scss/variables, json/flat, javascript/es6, typescript/es6-declarations. More formats might be affected by this.

To replicate, using style-dicitonary@3.7.2 & node@16.14.2, build basic example and see file examples/basic/build/scss/_variables.scss - it doesn't have newline on the final line. image

Thank you, looking forward to hear your input on this.

chazzmoney commented 1 year ago

Thanks for the note @AugustinasVainius. If you want to submit a PR for this, we would be happy to review it and merge it.

dbanksdesign commented 1 year ago

Looks like this was fixed and released! Closing this issue. Please reopen if it is still appearing.