search

amzn / style-dictionary

A build system for creating cross-platform styles.
https://styledictionary.com
Apache License 2.0
3.87k stars 543 forks source link

Ability to now run Tests in Parallel #961

Closed gillianyost closed 6 months ago

gillianyost commented 1 year ago

Now no longer need --runInBand for tests

While using this repo for a flaky test detection project, I have found that when your tests are run in parallel they have test dependencies which creates flaky tests. I have modified the test dependencies between test suites where the regular clearing of the tests/__output directory means the test suites cannot be run in parallel. Running in parallel is more efficient and thus in the package.json file the "--runInBand" command has been removed from the test command. There are now separate config files for the tests and the helper function that clears the output now takes a parameter to select which directory it clears.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

jorenbroekema commented 6 months ago

In v4 branch we use web test runner which runs each test file in a separate browser tab, number depends on concurrency.

Node tests were migrated to mocha, not currently in parallel due to some issues with Mocha's ESM support, but either way I think we can close this PR since we moved away from Jest, I explained some of that here https://github.com/amzn/style-dictionary/pull/1113#issuecomment-1988280585