search

amzn / style-dictionary

A build system for creating cross-platform styles.
https://styledictionary.com
Apache License 2.0
3.93k stars 557 forks source link

fix(types): fix FileHeader types #987

Closed alanbsmith closed 1 month ago

alanbsmith commented 1 year ago

Issue #, if available:

No issue, but I can create one if you'd like.

Description of changes:

I was looking at #708 when this was added, and several places in the code, but I don't see any reason this argument would be required as long as the provided function returns an array. And the tests don't seem to require it.

Happy to be proven wrong, but I think this would be a nice (albeit small) improvement for TS users. 😄

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

jorenbroekema commented 7 months ago

Hey, this seems like a sensible fix, could you rebase it onto the v4 branch and run npx changeset to add a patch changelog entry for it?

jorenbroekema commented 1 month ago

https://github.com/amzn/style-dictionary/pull/1351