search

an-anime-team / an-anime-game-launcher

An Anime Game launcher for Linux with telemetry disabling
https://discord.gg/ck37X6UWBp
GNU General Public License v3.0
1.57k stars 66 forks source link

Missing launcher icon in dash and activities overview in gnome #155

Closed saikat0511 closed 1 year ago

saikat0511 commented 1 year ago

Launcher is installed from AUR Screenshot from 2023-05-06 19-55-02

krypt0nn commented 1 year ago

@xstraok hi qq hello

xstraok commented 1 year ago

works fine on my system, even after reinstall

xstraok commented 1 year ago

what is the output of ls /usr/share/pixmaps | grep an-anime @saikat0511

saikat0511 commented 1 year ago

what is the output of ls /usr/share/pixmaps | grep an-anime @saikat0511

~ $ ls /usr/share/pixmaps | grep an-anime
an-anime-game-launcher.png
xstraok commented 1 year ago

icon should be visible. Does it show up in other desktop environments? And just in case, show output of ls -l /usr/share/pixmaps/an-anime-game-launcher.png and cat /usr/share/applications/an-anime-game-launcher.desktop

saikat0511 commented 1 year ago

Experimented a bit. It seems like it works fine on Xorg session but broken on wayland

saikat0511 commented 1 year ago

Seems like gnome wayland session handles desktop files and icons differently. Here's a similar issue from another project which was fixed, might help...

https://github.com/nextcloud/desktop/issues/1435#issuecomment-534696771

saikat0511 commented 1 year ago

Renaming the desktop file from an-anime-game-launcher.desktop to moe.launcher.an-anime-game-launcher.desktop fixes the issue. Gnome wayland expects desktop file, WM class and icon to be similarly named I guess...

saikat0511 commented 1 year ago

@xstraok Can you please update the desktop filename in AUR?

saikat0511 commented 1 year ago

Why was the change reverted? I tested it on plasma just to be sure and there were no issues

xstraok commented 1 year ago

the reason why i reverted it is because i realized that many people (including myself) have the launcher pinned on their panels/dashes/taskbars/etc...

By renaming the desktop file, it would render those old pinned launchers unusable, requiring users to re-pin.

I feared that this would cause lots of confusion, opened github issues, discord support threads and it would be a hassle to deal with all of that.

Besides, it's a gnome issue.