search

an-anime-team / an-anime-game-launcher

An Anime Game launcher for Linux with telemetry disabling
https://discord.gg/ck37X6UWBp
GNU General Public License v3.0
1.46k stars 66 forks source link

Incorrect free space check on installing patches #235

Open tigersoldier opened 11 months ago

tigersoldier commented 11 months ago

I have the 4.0 patch pre-downloaded. When trying to installing it, I got this error:

No free space available in the temp folder. Required: 101836989194. Available: 63418748928

The code is checking free space for archive size + unpack size, which doesn't make sense since the archive has already been downloaded. This line may be the culprit:

https://github.com/an-anime-team/anime-game-core/blob/c478d6ce1050d0d9ae661d34cd54dda0d82fc691/src/games/genshin/version_diff.rs#L396

krypt0nn commented 11 months ago

Noted. Thanks for the report.

I'm rewriting the core library right now and will consider your report (hope won't forget!)

If you don't have any way to install the update because of this - I can write some steps to update everything manually. Alternatively you could delete pre-downloaded files and let the launcher to download everything again, or free some space.

stvy-silli commented 3 months ago

I also have the same issue.

@krypt0nn did u forget?