search

an-anime-team / anime-launcher-sdk

Anime Game Launcher development SDK
GNU General Public License v3.0
17 stars 18 forks source link

Adding backend model and logic for FPS unlocker #6

Closed averageFOSSenjoyer closed 1 year ago

averageFOSSenjoyer commented 1 year ago

Notes

It is possible to modify HSR's maximum framerate via modifying the registry. It seems to only be able to take on 30 and 60, which are official options, or 120 which is not official.

This PR creates the logic for the modifying of the registry using the script during the run workflow. (May be better for the modification to occur when option is selected on UI?)

P.S.
  1. Better way to grant perm to the script?
  2. Make backup of the registry so it's easy to revert?

Testing

Only local tests so far, please pull the workspace and test it.

krypt0nn commented 1 year ago

Declined

  1. You want to use a standalone script to edit registry value which is literally a text file
  2. For whatever reason you added enum FpsStarRail, moreover - to the shared config_blanks space
  3. We've already proved that proper 120 fps patch is possible, but will require to modify game files which we won't do