search

an-cabal / an-rope

an rope data structure
https://docs.rs/an-rope
MIT License
11 stars 2 forks source link

Rewrite Node to not use Option #18

Closed hawkw closed 7 years ago

hawkw commented 7 years ago

This PR rewrites Rope to use Leaf("") rather than Option to represent empty nodes (see #16). It also fixes some additional issues in the Rope::*_insert_* method family, as well as bugs in iteration in the incorrect order.

Closes #16 Closes #7

hawkw commented 7 years ago

The only test that's still broken after all these commits is mutable_insert_char_test_1() which I have still not quite determined what the issue with is...

hawkw commented 7 years ago

Okay @cjm00, I think I've made all the changes you've requested?

hawkw commented 7 years ago

So b10dab635c86e39f08064190760a80342ecb65c7 fixes the one remaining failing test; we're all green now!

hawkw commented 7 years ago

@cjm00 I know you're travelling at the moment, but this PR should be merge-able, I think?

deepinthebuild commented 7 years ago

Yes, go for it.

On Dec 22, 2016 9:16 AM, "Eliza Weisman" notifications@github.com wrote:

@cjm https://github.com/cjm I know you're travelling at the moment, but this PR should be merge-able, I think?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hawkw/an-editor/pull/18#issuecomment-268819785, or mute the thread https://github.com/notifications/unsubscribe-auth/AETT5lVvphuuiZ0OsHqUzUe-EOJ12CLFks5rKpPJgaJpZM4LSIsH .