an-cabal / an-rope

an rope data structure

https://docs.rs/an-rope

MIT License

11 stars 2 forks source link

#78 replaced all instances of or_zero! with saturating_sub #80

Closed mclark4386 closed 7 years ago

mclark4386 commented 7 years ago

Should resolve #78! Please let me know if you would like me to tweak or change anything!

codecov-io commented 7 years ago

Codecov Report

Merging #80 into master will decrease coverage by 0.1%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   93.52%   93.41%   -0.11%     
==========================================
  Files           7        8       +1     
  Lines        1359     1382      +23     
==========================================
+ Hits         1271     1291      +20     
- Misses         88       91       +3

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 27f26ab...0bd19a2. Read the comment docs.

hawkw commented 7 years ago

Hi @mclark4386, this looks good, thank you!

For the future, if you're planning on making more commits to this project, I'd like to ask you to try to follow our commit message conventions. In this case, I can just merge your PR with a conforming commit message, but in the future, if you open a PR with several commits, I'd like them to be correctly formatted before merging.

hawkw commented 7 years ago

@rachlmac, since this issue was originally assigned to you, I'd like to make sure you're okay with me merging @mclark4386's changes?

rachlmac commented 7 years ago

@hawkw @mclark4386 That sounds good to me, thank you for your help with this one!

hawkw commented 7 years ago

And merged, thanks @mclark4386! Please feel free to check out any other issues, if you like.

mclark4386 commented 7 years ago

@hawkw @rachlmac Sorry about the incorrect formatting on the commit message. I did think about the format of the code, but didn't even cross my mind to be mindful of the commit message. Thank you for the critic and accepting the patch!