search

an-karpov / Credit_scoring

0 stars 0 forks source link

Upsampling error #1

Open CzSadykov opened 1 year ago

CzSadykov commented 1 year ago

Hey, Andrey! A really decent work you have, but allow me to respectfully notice that you upsampled the data before splitting the dataset into train and test sets, which leads to the data leakage and distorts the metrics.

Hope my commentary will be useful for you :)

an-karpov commented 1 year ago

Hey, Andrey! A really decent work you have, but allow me to respectfully notice that you upsampled the data before splitting the dataset into train and test sets, which leads to the data leakage and distorts the metrics.

Hope my commentary will be useful for you :)

Yes, you're right! Thank you!