an-tao / trantor

a non-blocking I/O tcp network lib based on c++14/17
Other
398 stars 134 forks source link

FATAL no writing but write callback called - TcpConnectionImpl.cc:328 #311

Closed prm-james-hill closed 6 months ago

prm-james-hill commented 10 months ago

I’m using Drogon’s HttpClient but figured it would make more sense to put this here:

I realize it’s a high ask to fix this under these conditions. I’m more curious if it’s safe to ignore this and if we can downgrade the log severity. I haven’t noticed any kind of memory corruption (though haven't actually had it happen under ASan) or resource exhaustion accompanying it.

(I also noticed this change from a couple hours ago. If that’s likely relevant I’m happy to upgrade and report back when it’s released.)

an-tao commented 10 months ago

@prm-james-hill Thanks so much for your feedback. You can try the latest modifications, I'm currently simplifying the internal logic of this part and maybe it can fix this problem (#308). But don't check the #308 PR, it's still under development

prm-james-hill commented 10 months ago

Thanks for the context, An. If you’re in the process of doing more changes then I’ll just wait for them all to get released. And once I upgrade to that I can report back

an-tao commented 10 months ago

@prm-james-hill Would u please check out the PR #312 ?

prm-james-hill commented 10 months ago

Sorry for the delayed response. I have to hold off until it’s released. I realize that doesn’t really promise there aren’t bugs, but the only environment I can repro in is risky/difficult to change (especially this time of year)

prm-james-hill commented 6 months ago

Finally had a chance to try this out. I’m no longer seeing these on Trantor 1.5.17 (via Drogon 1.9.3). Thanks, An!