an0nym0u5 / growl

Automatically exported from code.google.com/p/growl
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

GrowlVersionUtilities.m, NSStringAdditions.m, GrowlNotificationRowView.h lack newline at EOF #490

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Try to compile growl 1.3.3 with clang and -Werror
2. See the build erroring out because a few files lack newlines at the end of 
the file

What is the expected output?
If the files had newlines at EOF, the compiler wouldn't error.

What do you see instead?
The compiler aborts compilation because of missing newlines at EOF.

Please use labels and text to provide additional information.
Files should always have newlines at their end. The attached patch fixes those 
issues.

Original issue reported on code.google.com by neverpa...@gmail.com on 1 Jun 2012 at 11:36

Attachments:

GoogleCodeExporter commented 8 years ago
We're not going to be fixing 1.3.3, since 1.4 has been pushed to the app store. 
Once it is approved, we'll push 1.4 source which does not have this issue.

We appreciate your work on this, but there have been tickets on this 
previously, and I wish you had talked to us about it first we would have told 
you the same thing (say, in irc) without you having to go through the trouble 
of making the patch. :)

Original comment by ch...@growl.info on 2 Jun 2012 at 2:15