an0rak-dev / vscode-gcp-cloudbuild

[LOOKING FOR A NEW MAINTAINER] Add GCP CloudBuild support in VSCode
Apache License 2.0
2 stars 1 forks source link

Increasing code coverage for `cloudbuild`. #10

Closed jkaluzka closed 4 years ago

jkaluzka commented 4 years ago

types file was created to store existing and future types.

Type of modification

Changes description

Add some quick description about what your PullRequest change in vscode-gcp-cloudbuild's feature/behavior

Increasing code coverage for cloudbuild. Relates to #1

Technical description

Add a quick description about what your PullRequest change in vscode-gcp-cloudbuild's code. (example: add a processor check in...)

The new test file was created including test implementations. types file was created to keep types separately.

PR CheckList

Please make sure your PullRequest respect all those items :

an0rak-dev commented 4 years ago

Hi @jkaluzka

Thanks for this work 😄 I added some reviews on it (nothing to big 😉 ).

Also, I'm currently planning to refactor the architecture of the plugin to use a more OOP approach (and add a real separations between each modules), with the purpose on developing a big feature for the next version (see #12 -- draft for now). I think that I would report all your tests contributions in it and keep a good quality in the source thanks to your work.

Would you be interested to review the refactor when I'm done with it ? 😄

PS: For the refactor branch, I think that I'll add a linting convention to avoid all those different identations and formats between contributors :D