Fix handling of multiline dependency list with a single-line comment inside

anacierdem / vscode-requirejs

Provides goto definition functionality for require js modules.

MIT License

21 stars 14 forks source link

Fix handling of multiline dependency list with a single-line comment inside #45

Closed prantlf closed 6 years ago

prantlf commented 6 years ago

Aims to fix #44.

Edge cases of the regex used should not occur within the define or require statements.

prantlf commented 6 years ago

There seems to be a problem with the Travis build environment:

Xlib:  extension "RANDR" missing on display ":99.0".
{ errorCode: 'load',
  moduleId: 'keytar',
  neededBy: [ 'vs/platform/credentials/node/credentialsService' ],
  detail: 
   Error: libsecret-1.so.0: cannot open shared object file: No such file or directory
       at process.module.(anonymous function) [as dlopen] (ELECTRON_ASAR.js:173:20)

Local tests run fine.

anacierdem commented 6 years ago

Seems like travis is unable to initialize vscode, will check that.

anacierdem commented 6 years ago

Have you seen my email @prantlf ?