DaBs commented 6 years ago

This pull requests allows for custom require and define definitions. This is relevant in relation to e.g. curl.js (yes, I'm aware that it's highly outdated, but we're still stuck using it in our current architecture :disappointed: ), where you can rename the require and define keywords to avoid collision with e.g. vendor specific versions.

You could rename define to defineCustomName and it would still resolve.

codecov-io commented 6 years ago

Codecov Report

Merging #48 into master will increase coverage by 0.06%. The diff coverage is 50%.

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   56.55%   56.62%   +0.06%     
==========================================
  Files           1        1              
  Lines         244      249       +5     
  Branches       52       55       +3     
==========================================
+ Hits          138      141       +3     
- Misses        106      108       +2

Impacted Files	Coverage Δ
extension.js	`56.62% <50%> (+0.06%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 99b2402...cd689d0. Read the comment docs.

anacierdem commented 6 years ago

Could you please fix the failing test?

DaBs commented 6 years ago

Should be fixed now, I was initializing the work on getting IntelliSense working too, but didn't realise that it would affect this pull request

anacierdem / vscode-requirejs

Allows custom define and require definitions #48

Codecov Report