search

anacierdem / vscode-requirejs

Provides goto definition functionality for require js modules.
MIT License
21 stars 14 forks source link

Support navigation to a jsx file #58

Closed ayush000 closed 5 years ago

ayush000 commented 5 years ago

This is a hacky way to add support for navigating to jsx files.

codecov-io commented 5 years ago

Codecov Report

Merging #58 into master will decrease coverage by 0.06%. The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage      80%   79.93%   -0.07%     
==========================================
  Files           3        3              
  Lines         305      309       +4     
  Branches       65       66       +1     
==========================================
+ Hits          244      247       +3     
- Misses         61       62       +1
Impacted Files Coverage Δ
ReferenceProvider.js 91.94% <80%> (-0.3%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 294176b...3b0d9e1. Read the comment docs.

anacierdem commented 5 years ago

I didn't like the idea of appending a random x character to the end of file and doing a sync file test. Have you tried requireModuleSupport.pluginExtensions option and import like jsx!/src/moduleA ? This seems like a better solution than changing the code like that?

anacierdem commented 5 years ago

I have verified now, requireModuleSupport.pluginExtensions option and import like jsx!/src/moduleA works fine. Better than this solution.