Inter channel

[jjhelmus]

There is still many tests failing and a few flake8 errors. For example:

_____________________________ test_submit_one_off ______________________________
Traceback (most recent call last):
  File "/home/travis/build/conda/conda-concourse-ci/tests/test_execute.py", line 131, in test_submit_one_off
    config_root_dir=test_config_dir)
  File "/home/travis/build/conda/conda-concourse-ci/conda_concourse_ci/execute.py", line 1218, in submit_one_off
    pass_throughs=pass_throughs, **kwargs)
  File "/home/travis/build/conda/conda-concourse-ci/conda_concourse_ci/execute.py", line 1041, in compute_builds
    pass_throughs=pass_throughs, skip_existing=skip_existing)
  File "/home/travis/build/conda/conda-concourse-ci/conda_concourse_ci/execute.py", line 117, in collect_tasks
    config=config)
  File "/home/travis/build/conda/conda-concourse-ci/conda_concourse_ci/compute_build_graph.py", line 425, in construct_graph
    recipes_dir, config=config, finalize=finalize)
  File "/home/travis/build/conda/conda-concourse-ci/conda_concourse_ci/compute_build_graph.py", line 216, in add_recipe_to_graph
    recipes_dir=recipes_dir, finalize=finalize)
  File "/home/travis/build/conda/conda-concourse-ci/conda_concourse_ci/compute_build_graph.py", line 478, in add_dependency_nodes_and_edges
    metadata = graph.nodes[node]['meta']
TypeError: 'method' object is not subscriptable
----------------------------- Captured stdout call -----------------------------

$ flake8
./conda_concourse_ci/uploads.py:42:1: E302 expected 2 blank lines, found 1
./conda_concourse_ci/execute.py:287:16: E225 missing whitespace around operator
./conda_concourse_ci/execute.py:289:20: E225 missing whitespace around operator

[katietz]

No, there is no token required AFAIK. See also the comment below in the other 'anaconda upload' method. It explicit claims, either user or token.

Regards Kai

On Wed, Apr 29, 2020 at 6:45 PM Jonathan J. Helmus notifications@github.com wrote:

@jjhelmus commented on this pull request.

In conda_concourse_ci/uploads.py https://github.com/conda/conda-concourse-ci/pull/148#discussion_r417459758 :

@@ -32,6 +32,13 @@ def _base_task(upload_job_name): }}

+def upload_staging_channel(user, package_path):

• """
• Upload to anaconda.org using user.
• """
• cmd = 'upload --skip-existing --force -u {} {}'.format(user, package_path)

Is a token required here?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/conda/conda-concourse-ci/pull/148#pullrequestreview-402850536, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALJLMJCCAKSM736DKACGC7DRPBKTXANCNFSM4MS3PLMA .

[katietz]

The issue about 'TypeError: 'method' object is not subscriptable ' is the use of networkx <2. Therefore I added to conda.recipe the requirement to use >=2.0 version. That issue is well described on migration advices from 1.9 to 2.x networkx

Hope that fixes it. You might run into pip issues, and you might need to update pip package?

On Wed, Apr 29, 2020 at 8:42 PM Kai Tietz ktietz@anaconda.com wrote:

No, there is no token required AFAIK. See also the comment below in the other 'anaconda upload' method. It explicit claims, either user or token.

Regards Kai

On Wed, Apr 29, 2020 at 6:45 PM Jonathan J. Helmus < notifications@github.com> wrote:

@jjhelmus commented on this pull request.

In conda_concourse_ci/uploads.py https://github.com/conda/conda-concourse-ci/pull/148#discussion_r417459758 :

@@ -32,6 +32,13 @@ def _base_task(upload_job_name): }}

+def upload_staging_channel(user, package_path):

• """
• Upload to anaconda.org using user.
• """
• cmd = 'upload --skip-existing --force -u {} {}'.format(user, package_path)

Is a token required here?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/conda/conda-concourse-ci/pull/148#pullrequestreview-402850536, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALJLMJCCAKSM736DKACGC7DRPBKTXANCNFSM4MS3PLMA .

[jjhelmus]

LGTM, thanks @katietz