anaconda-graveyard / nb_anacondacloud

Interact with Anaconda Cloud
BSD 2-Clause "Simplified" License
5 stars 9 forks source link

Login ui #13

Closed malev closed 8 years ago

malev commented 8 years ago

Because login using the command line is the worst @damianavila @mmarchetti @bollwyvl screen shot 2016-02-12 at 4 18 12 pm screen shot 2016-02-12 at 4 18 23 pm

bollwyvl commented 8 years ago

In addition to the comments above, we should also offer the opportunity to create a user on anaconda cloud... i'm wagering a fair number of users who would want to publish notebooks have been using anaconda.org in a primarily read-only mode, and this is a great way to turn such users, about which we can say very little, into authorized users. Indeed, a bucket of users of "signed up, then shortly published a notebook" is actually a pretty good market segment.

malev commented 8 years ago

Also, if we are providing login, we should probably also provide the option to set the login URL. this is of course tricky, as the user would only know the HTML URL, not the API URL. Presumably, this would just mean throwing /api onto anything other than anaconda.org

Don't fully understand this. I don't think the user cares about the endpoint.

malev commented 8 years ago

In addition to the comments above, we should also offer the opportunity to create a user on anaconda cloud... i'm wagering a fair number of users who would want to publish notebooks have been using anaconda.org in a primarily read-only mode, and this is a great way to turn such users, about which we can say very little, into authorized users. Indeed, a bucket of users of "signed up, then shortly published a notebook" is actually a pretty good market segment.

I agree with you here but, I think it's gonna be easy if we just link them to the sign up page in AC. At least for now.

bollwyvl commented 8 years ago

Don't fully understand this. I don't think the user cares about the endpoint.

Think on-premises/enterprise/trial box. If it hadn't been configured previously for them, it might be confusing... and I don't think the custom anaconda/miniconda installer made it in.

I agree with you here but, I think it's gonna be easy if we just link them to the sign up page in AC. At least for now.

Yup. No reason to do anything fancy, just have a link/button:

Don't have an Anaconda Cloud username? Register now at anaconda.org

It may also be worthwhile, on a failed login, to offer them the password help link.

malev commented 8 years ago

Ok, I see what you are saying now!

@bollwyvl @damianavila

bollwyvl commented 8 years ago
  • I added the forgot username and password's link

Sounds good!

  • This won't go on the trial box
  • I believe I need to add the enterprise option, but I just wanted to have this working for now. We can add that later

@ijstokes can you comment on this? I feel nb_anacondacloud is pretty key to the whole low-friction worflow for getting a data scientists work into others' hands, which is a pretty strong part of the story.

ijstokes commented 8 years ago

@bollwyvl yes, you are quite right in thinking that we want to create a natural flow from Anaconda Local (on the user's workstation) to Anaconda Enterprise (or Cloud). This is a piece we should address sooner rather than later, so I'm adding a backlog item for it: https://github.com/Anaconda-Server/anaconda-nb-extensions/issues/151

In the mean time I'll try to merge master into the branch and see if I can trigger another build/test sequence. If that works and passes, I'll merge.

ijstokes commented 8 years ago

@malev I'd love to merge this, but I can't make sense of the build failures for everything except win-64 (what a surprise!): https://anaconda.org/anaconda-nb-extensions/nb_anacondacloud/builds/28

bollwyvl commented 8 years ago

Sorry, just saw this!

Here's the key line:

FAIL Find "Unauthorized" within the selector " h4.modal-title"

520#    type: assertSelectorHasText

521#    file: /home/anaconda/miniconda/envs/_test/lib/python2.7/site-packages/nb_anacondacloud/tests/js/noauth/test_50_noauth.js:16

522#    code: t.assertSelectorHasText(" h4.modal-title", "Unauthorized");

523#    subject: false

524#    selector: " h4.modal-title"

525#    text: "Unauthorized"

526#    actualContent: "Sign in to "

527PASS I can see and click the dismiss button

It's just because the text changed, due to the new login verbiage. I'll take a look at it!

bollwyvl commented 8 years ago

I'm getting early aborts from the test on windows 64... i think i've seen this before, and just need a communicate instead of a check_output. Oh windows.

bollwyvl commented 8 years ago

Related to this: https://github.com/Anaconda-Server/anaconda-nb-extensions/issues/128

malev commented 8 years ago

I packaged node 4.4.0 for windows and now this is working. so MERGEEEEE :smile: :+1: :factory:

bollwyvl commented 8 years ago

Yeah, that's awesome :rocket: :guitar: !

bollwyvl commented 8 years ago

@malev @damianavila who wants to do the release engineering? What should the version be?

damianavila commented 8 years ago

I guess we should bump the version to to 0.1.3... in the conda recipe and the internal setup.py (currently master have a mismatch), we also need to make this somewhat automated in the future... in fact, I started to work on that before vacation...