search

anaconda-graveyard / nb_anacondacloud

Interact with Anaconda Cloud
BSD 2-Clause "Simplified" License
5 stars 9 forks source link

Fix to attach the current environment #35

Closed damianavila closed 7 years ago

damianavila commented 7 years ago

We should attach the env we are currently running on, not the default one. So, we get the env name from the kernelspec and we use that to actually get the proper conda list for that environment.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-1.4%) to 48.305% when pulling 7bb5e90a70b6c03647ca407116a6c11b50523883 on fix_attach_env into be8fca6bfe06cd3fc12526d829d467d13a88c8ba on master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.6%) to 49.157% when pulling 352ff3065c41cd40e69bc2cc8afe13298fac3e84 on fix_attach_env into be8fca6bfe06cd3fc12526d829d467d13a88c8ba on master.

damianavila commented 7 years ago

@martindurant, a quick look if you have time :wink: Thanks!

damianavila commented 7 years ago

Merging now...

martindurant commented 7 years ago

hah, a quick look :) I found no problem here.

damianavila commented 7 years ago

hah, a quick look :)

Yep, sorry for merging so quickly... I needed to merge it to build the packages in conda-forge... at the end I changed the strategy (and build local packages) because it was not building on conda-forge...